-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gets Baseline Test Working With Current State of Codebase #91
Conversation
@julianstirling I'll work on fixing the pylint errors in the shelf.py module. |
Thanks! |
@julianstirling Everything is green now, and the new test is running in CI. However, you may take issue with my removal of the In the interest of doing smaller PRs that handle one thing at a time, I'll take this out of draft so that it can be fully reviewed. Once we iterate and it is merged, I'll move on to assemblies and renders. |
I am wondering if rather than commenting out the currently unfinished functions to make pylint happen we instead add:
into the functions just before the This will silence the error but let us have the methods in place ready? |
I'm happy with pulling the TODOs out of the RC file. |
Ok, that has been implemented in the latest commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this. Great to have tests, docstrings, and to have the linter passing again.
This is done in preparation for moving to assembly CAD and rendering.