-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Shelf-Device Assembly and Rendering #92
Conversation
@jmwright The problem with the text CI is that when pip installed without |
Thanks @julianstirling , I was wasting too much time not understanding that. |
We probably want to add a |
@julianstirling Are you suggesting that should be part of this PR? |
…the shelf-device assembly
…a record of what they were
…ons in the plugin
Here are two samples of the shelf assembly rendering at work. One is the default with full color, the second is with a configurable black-and-white "theme" that is more in line with traditional annotated drawings. I left the automated assembly lines in place for both, and I left the assembly exploded. I'm a little disappointed in how the CAD kernel renders some edges, especially in the black-and-white version, but I think it's passable. |
@julianstirling I have marked this as ready for review. |
# Hole location parameters | ||
_screw_dist_x = None | ||
_screw_dist_y = None | ||
_dist_to_front = None | ||
_offset_x = None |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can imagine that for some of the shelves we will need different variables because most don't have screws coming top-down. some come in from the sides. We may want to move these attributes to the specific classes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
because most don't have screws coming top-down. some come in from the sides. We may want to move these attributes to the specific classes.
There is a parameter for this. You set the axis of alignment for the screw to get it in the right orientation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Jeremy, lots of hard work in this one. I love the render examples.
I think it's time to get these merged in. We can think about generalising to other shelves later.
@julianstirling Where does (or should) the screw location information live? At a minimum I need a location and an axis for each screw. The axis could be something like +Y and -Y so that I can have the correct orientation of the screw relative to the hole it's going into.