Open
Conversation
imp
approved these changes
Mar 6, 2025
mnp
approved these changes
Mar 6, 2025
s3/src/bucket.rs
Outdated
| use http::HeaderMap; | ||
|
|
||
| pub const CHUNK_SIZE: usize = 268_435_456; // 256 Mebibytes (8 wasn't enough), min is 5 (5_242_880); | ||
| pub const CHUNK_SIZE: usize = 16_777_216; // 16 Mebibytes (8 wasn't enough), min is 5 (5_242_880); |
There was a problem hiding this comment.
This block size is needed to support uploading 70B models since S3 protocol only allows a max of 10k blocks.
JONBRWN
reviewed
Mar 7, 2025
| use http::HeaderMap; | ||
|
|
||
| pub const CHUNK_SIZE: usize = 268_435_456; // 256 Mebibytes (8 wasn't enough), min is 5 (5_242_880); | ||
| pub const CHUNK_SIZE: usize = 33_554_432; // 32 Mebibytes (8 wasn't enough), min is 5 (5_242_880); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.