fix(cli-sdk): route sign-typed-data requests to correct chain#37
Merged
Conversation
cmdSignTypedData was always sending eth_signTypedData_v4 requests on eip155:1 (the first account) regardless of the typed data's actual chainId. Wallets like Zerion would ignore or expire requests sent on the wrong chain, causing silent failures. Now extracts chainId from the typed data domain and finds the matching account (e.g. eip155:137 for Polygon) before sending the request. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cmdSignTypedDatawas always sendingeth_signTypedData_v4requests oneip155:1(first account) regardless of the typed data's actualchainIdchainIdfrom the typed data domain and finds the matching account (e.g.eip155:137for Polygon) before sending the requestTest plan
sign-typed-datawith typed data containing a domainchainIdmatching the connected chain🤖 Generated with Claude Code