Feat/seedless onboarding #2
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ieow
reviewed
Mar 21, 2025
| * @returns A promise that resolves to the authentication result. | ||
| */ | ||
| async authenticateOAuthUser(params: AuthenticateUserParams) { | ||
| const verificationResult = await this.#toprfAuthClient.authenticate(params); |
There was a problem hiding this comment.
Shouldn't the controller store the verificationResult ( AuthToken ) in the controller state?
the createSeedPhrase and other function will not need the authToken params.
the app also do not need to find place to store the AuthToken
There was a problem hiding this comment.
Yes, agree. They should be stored in SeedlessControllerState.
I have not added them into state yet, coz the toprf-sdk interfaces are not ready yet.
I will push new commits for that soon.
ieow
reviewed
Mar 24, 2025
| export const defaultState: SeedlessOnboardingControllerState = {}; | ||
| const seedlessOnboardingMetadata: StateMetadata<SeedlessOnboardingControllerState> = | ||
| { | ||
| nodeAuthTokens: { |
There was a problem hiding this comment.
Should allow the seedless onboarding controller's constructor to set the initial state
export getDefaultSeedlessOnboardingControllerState that return this default state
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
References
Changelog
@metamask/package-a@metamask/package-bChecklist