v4: feat: remote signer #185
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ieow
force-pushed
the
feat/remoteSigner-V3
branch
from
c33d0d0 to
ef7e61f
Compare
remoteSigner
fix rehydration
ieow
force-pushed
the
feat/remoteSigner-V3
branch
from
5f8870f to
57472c3
Compare
himanshuchawla009
requested changes
Dec 4, 2024
src/mpcCoreKit.ts
Outdated
| } | ||
| } | ||
|
|
||
| async setupRemoteSigning(params: Omit<IRemoteClientState, "tssShareIndex" | "signatures">): Promise<void> { |
Member
There was a problem hiding this comment.
i think this function can be moved to plugin itself
src/mpcCoreKit.ts
Outdated
| msgHash: msgData.toString("hex"), | ||
| }; | ||
|
|
||
| const result = await post<{ data?: Record<string, string> }>(`${this.state.remoteClient.remoteClientUrl}/api/v3/mpc/sign/dkls`, data, { |
Member
There was a problem hiding this comment.
this logic should be moved to a function in plugin so that we can be decoupled from api endpoints here, i think another way to do it is to do it directly inside existing sign function since most of the code is same and call the remoteSign function same as we are doing for copyShare logic.
| }; | ||
| await this.sessionManager.createSession(payload); | ||
| // to accommodate async storage | ||
| await this.currentStorage.set("sessionId", sessionId); |
Member
There was a problem hiding this comment.
this function should be moved to plugin as well
Contributor
Author
|
close in favor of #209 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remoteSigner
Motivation and Context
Jira Link:
Description
How has this been tested?
Screenshots (if appropriate):
Types of changes
Checklist: