Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: removed isSessionIdExists method and modified tests. #11

Merged
merged 14 commits into from
Nov 6, 2024
Merged

feat: removed isSessionIdExists method and modified tests. #11

merged 14 commits into from
Nov 6, 2024

Conversation

grvgoel81
Copy link
Collaborator

@grvgoel81 grvgoel81 commented Sep 20, 2024 •
edited
Loading

Motivation and Context

  • Removed isSessionIdExists() method
  • logout() function added.
  • Modified tests.
  • Refactored sdk as per web sfa sdk.

Jira Link: https://toruslabs.atlassian.net/browse/PD-4112

Description

  • Removed isSessionIdExists() method
  • logout() function added.
  • Modified tests.
  • Refactored sdk as per web sfa sdk.

Screenshots (if appropriate):

Screenshot 2024-09-20 at 1 34 24 PM
Screen.Recording.2024-11-06.at.8.40.10.AM.mov

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project. (run lint)
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@grvgoel81 grvgoel81 changed the title feat: update isSessionIdExists method and modified tests. feat: removed isSessionIdExists method and modified tests. Sep 25, 2024
@metalurgical
Copy link
Contributor

PR is good overall, please see comments for some things that need addressing.

chaitanyapotti
chaitanyapotti approved these changes Nov 6, 2024
View reviewed changes
Copy link
Member

@chaitanyapotti chaitanyapotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

feat: Resolved PR comments
6559637 
Signed-off-by: Gaurav Goel <[email protected]>
@grvgoel81 grvgoel81 merged commit 6f85454 into master Nov 6, 2024
2 checks passed
@grvgoel81 grvgoel81 deleted the update-isSessionIdExists-method branch November 6, 2024 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@metalurgical metalurgical metalurgical left review comments

@chaitanyapotti chaitanyapotti chaitanyapotti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@grvgoel81 @metalurgical @chaitanyapotti