Skip to content

feat: manageMFA functionality #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 7, 2025
Merged

feat: manageMFA functionality #42

merged 3 commits into from
Apr 7, 2025

Conversation

grvgoel81
Copy link
Contributor

@grvgoel81 grvgoel81 commented Mar 12, 2025 •
edited
Loading

Motivation and Context

  • manageMFA functionality added.

Jira Link: https://toruslabs.atlassian.net/browse/PD-4387

Description

  • manageMFA function added

How has this been tested?

  • In unity editor
  • In emulator

Screenshots (if appropriate):

Screen.Recording.2025-03-14.at.11.14.52.AM.mov
manageMFA_android.mp4

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project. (run lint)
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My code requires a db migration.

grvgoel81 and others added 3 commits March 12, 2025 15:32
@grvgoel81
feat: manageMFA initial vcommit
137c2ab 
Signed-off-by: Gaurav Goel <[email protected]>
@grvgoel81
feat: manageMFA added.
1b1bb60 
Signed-off-by: Gaurav Goel <[email protected]>
@grvgoel81
feat: manageMFA added.
372e558 
Signed-off-by: Gaurav Goel <[email protected]>
@grvgoel81 grvgoel81 marked this pull request as ready for review March 14, 2025 08:59
shahbaz17
shahbaz17 approved these changes Apr 4, 2025
View reviewed changes
Copy link
Member

@shahbaz17 shahbaz17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Tested locally, works well with Google and EmailPasswordless

chaitanyapotti
chaitanyapotti approved these changes Apr 7, 2025
View reviewed changes
Copy link
Member

@chaitanyapotti chaitanyapotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chaitanyapotti chaitanyapotti merged commit d6a4f2b into master Apr 7, 2025
3 checks passed
@chaitanyapotti chaitanyapotti deleted the feat/manage_mfa branch April 7, 2025 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chaitanyapotti chaitanyapotti chaitanyapotti approved these changes

@shahbaz17 shahbaz17 shahbaz17 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@grvgoel81 @chaitanyapotti @shahbaz17