feat(contract): enhance contract safety and validation#1292
Merged
martinvibes merged 1 commit intoJun 28, 2026
Merged
Conversation
|
@rhoggs-bot-test-account is attempting to deploy a commit to the shola's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@serverlessdomain-hash Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Resolves Web3Novalabs#1124: Restrict config initialization after setup. Resolves Web3Novalabs#1126: Verify proxy upgrade authorization checks. Resolves Web3Novalabs#1127: Support whitelist token addresses for staking. Resolves Web3Novalabs#1129: Enforce reentrancy guard for payout claims.
serverlessdomain-hash
force-pushed
the
fix-contract-safety-issues
branch
from
ceaa9e3 to
a0fbdb5
Compare
Collaborator
|
Nice implementation! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enhances the contract safety by adding several critical checks.
Resolves #1124
Resolves #1126
Resolves #1127
Resolves #1129
Changes Made:
init()to panic withPredifiError::AlreadyInitializedOrConfigNotSetif the configuration is already present, preventing double-initialization.upgrade_contractenforces the proper proxy upgrade authorizations via the access-control role 0 (Admin).is_token_whitelistedcheck directly intoplace_predictionto ensure users cannot stake with tokens that have been delisted post-pool-creation.enter_reentrancy_guardandexit_reentrancy_guardproperly guard all payout paths (claim_winnings_internal,claim_refund,withdraw_treasury).