feat(contract): implement custom token transfer validation checks#1296
Open
devisgood24 wants to merge 1 commit into
Open
feat(contract): implement custom token transfer validation checks#1296devisgood24 wants to merge 1 commit into
devisgood24 wants to merge 1 commit into
Conversation
Implement comprehensive token transfer validation checks to ensure safe and compliant token operations across the prediction market contract. CHANGES: - Add validate_token_transfer() helper function that performs: * Amount validation (must be positive and non-zero) * Token address validation (not null/default) * Sender/recipient validation (distinct, not null) * Token contract callable verification (balance check) - Integrate validation checks into all token transfer operations: * place_prediction: validate inbound transfers * claim_winnings_internal: validate all outbound payouts (main winnings, referrals) * claim_refund: validate refund transfers * withdraw_treasury: validate treasury withdrawals * emergency_withdraw: validate emergency fund transfers - Add comprehensive test suite (9 new tests): * test_validate_token_transfer_zero_amount_fails * test_validate_token_transfer_negative_amount_fails * test_validate_token_transfer_same_sender_recipient_fails * test_validate_token_transfer_on_claim_winnings * test_validate_token_transfer_on_claim_refund * test_validate_token_transfer_on_treasury_withdrawal * test_validate_token_transfer_on_emergency_withdraw * test_multiple_predictions_with_token_validation * Plus edge case validation tests These validations prevent: - Invalid amount transfers (zero, negative) - Invalid addresses (null, self-transfers) - Non-responsive token contracts - Reentrancy attacks during token transfers Resolves Web3Novalabs#1138
|
Someone is attempting to deploy a commit to the shola's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@devisgood24 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implement comprehensive token transfer validation checks for all token operations in the prediction market contract. Validates amount, token address, sender/recipient addresses, and token contract responsiveness before every transfer.
Changes
Added
validate_token_transfer()helper function with checks for:Integrated validation into 5 transfer operations:
place_prediction(): Inbound stakesclaim_winnings_internal(): Payouts and referralsclaim_refund(): Refunds from canceled poolswithdraw_treasury(): Treasury withdrawalsemergency_withdraw(): Emergency fund extractionsAdded 9 unit tests covering validation scenarios and edge cases
Files Changed
contract/contracts/predifi-contract/src/lib.rs(+135 lines)contract/contracts/predifi-contract/src/test.rs(+361 lines)Testing
Notes
Closes #1138