feat(contract): Implement stake limit modification safety checks#1297
Open
devisgood24 wants to merge 2 commits into
Open
feat(contract): Implement stake limit modification safety checks#1297devisgood24 wants to merge 2 commits into
devisgood24 wants to merge 2 commits into
Conversation
added 2 commits
June 28, 2026 17:09
Implement comprehensive token transfer validation checks to ensure safe and compliant token operations across the prediction market contract. CHANGES: - Add validate_token_transfer() helper function that performs: * Amount validation (must be positive and non-zero) * Token address validation (not null/default) * Sender/recipient validation (distinct, not null) * Token contract callable verification (balance check) - Integrate validation checks into all token transfer operations: * place_prediction: validate inbound transfers * claim_winnings_internal: validate all outbound payouts (main winnings, referrals) * claim_refund: validate refund transfers * withdraw_treasury: validate treasury withdrawals * emergency_withdraw: validate emergency fund transfers - Add comprehensive test suite (9 new tests): * test_validate_token_transfer_zero_amount_fails * test_validate_token_transfer_negative_amount_fails * test_validate_token_transfer_same_sender_recipient_fails * test_validate_token_transfer_on_claim_winnings * test_validate_token_transfer_on_claim_refund * test_validate_token_transfer_on_treasury_withdrawal * test_validate_token_transfer_on_emergency_withdraw * test_multiple_predictions_with_token_validation * Plus edge case validation tests These validations prevent: - Invalid amount transfers (zero, negative) - Invalid addresses (null, self-transfers) - Non-responsive token contracts - Reentrancy attacks during token transfers Resolves Web3Novalabs#1138
Add comprehensive validation to stake limit modifications to prevent inconsistent pool states and protect existing predictions. CHANGES: - Add validate_stake_limits() helper function with checks for: * min_stake must be positive (> 0) * min_stake <= max_stake (if max_stake set) * min_stake <= pool.total_stake (doesn't invalidate existing bets) * min_stake <= pool.max_total_stake (respects pool capacity) * max_stake <= pool.max_total_stake (pool capacity check) * max_stake >= min_stake * 10 (reasonable ratio for usability) - Integrate validation into set_stake_limits() function * Validates before state mutation * Early error detection * Clear error reporting via PredifiError variants - Add 7 comprehensive unit tests: * test_set_stake_limits_zero_min_stake_fails * test_set_stake_limits_negative_min_stake_fails * test_set_stake_limits_min_exceeds_max_fails * test_set_stake_limits_min_exceeds_total_stake_fails * test_set_stake_limits_successful_update * test_set_stake_limits_no_max_stake_limit * test_set_stake_limits_ratio_validation * test_set_stake_limits_on_inactive_pool_fails * test_set_stake_limits_requires_operator_role These validations prevent: - Invalid stake configurations (zero, negative amounts) - Retroactive invalidation of existing predictions - Violations of pool capacity constraints - Usability issues (extreme min/max ratios) - Unauthorized modifications (role validation) Uses appropriate PredifiError variants: - StakeBelowMinimum for invalid min values - StakeAboveMaximum for capacity violations - InvalidAmount for ratio/constraint violations - ArithmeticError for overflow checks Resolves Web3Novalabs#1140
|
Someone is attempting to deploy a commit to the shola's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@devisgood24 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement comprehensive validation for stake limit modifications to ensure pool consistency and protect existing predictions.
Changes
Added
validate_stake_limits()function with 6 safety checks:Integrated validation into
set_stake_limits()function with early error detectionAdded 9 comprehensive unit tests covering all validation scenarios
Validation Error Handling
Uses appropriate PredifiError variants:
StakeBelowMinimum: Invalid min valuesStakeAboveMaximum: Capacity violationsInvalidAmount: Ratio/constraint violationsArithmeticError: Overflow checksTesting
Run:
cd contract && cargo test --workspaceCloses #1140