Make close-{readable,writable} symmetric in taking an optional error-context #446
+75
−89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukewagner
force-pushed
the
symmetric-error
branch
from
be4acab to
57f2769
Compare
alexcrichton
added a commit
to alexcrichton/wasm-tools
that referenced
this pull request
Feb 24, 2025
Account for changes in WebAssembly/component-model#446 and update the validation here to expect two `i32` parameters instead of only one.
alexcrichton
added a commit
to alexcrichton/wasm-tools
that referenced
this pull request
Feb 24, 2025
Account for changes in WebAssembly/component-model#446 and update the validation here to expect two `i32` parameters instead of only one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 0.3 updates to
wasi:httpin wasi-http/#143 helped highlight the fact that the reasoning for why we want to be able to pass anerror-contextintostream.close-readableand get anerror-contextout ofstream.readapplies just as well in the opposite direction (tostream.close-writableandstream.write, resp.). This PR basically just removes one of the few asymmetries from the otherwise-quite-symmetric read/write code.