[js-api] Add test case for externref global #1983
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 23, 2025
Open
Ms2ger
requested changes
Oct 16, 2025
Comment on lines
+188
to
+189
| ]) { | ||
| global.value = value; |
There was a problem hiding this comment.
Isn't this going to throw an assertion in step 5 because you didn't pass mutable: true in the constructor?
Comment on lines
+187
to
+192
| () => null | ||
| ]) { | ||
| global.value = value; | ||
| assert_Global(global, value); | ||
| } | ||
| }, "externref global"); |
There was a problem hiding this comment.
This case isn't testing the constructor, which is what this file is for. I believe there's a file for the value getter/setter nearby
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should add some basic coverage for externref globals.
(We should extend this if #1980 results in adding more allowed types.)