Vite migration + added header #74
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marviem
requested changes
Aug 11, 2025
There was a problem hiding this comment.
Аня, дякую дуже за апдейтики)
глянула, полишала коменти невеличкі
ще які думки загальні:
- ми оновили версії react та vite, мінімальна необхідна версія ноди після цього мала піднятися — треба б чекнути і оновити версії в рідмішках в пререквізітах
- іноді форматування коду по файлах трохи неконсістент — хотіла запропонувати пройтися якимось prettier-ом, щоб усе однаково поформатовано було)
fixes according to the comments (except readme)
marviem
requested changes
Aug 15, 2025
|
|
||
| ## Prerequisites | ||
|
|
||
| - [Node.js 6 or later](https://nodejs.org/en/) | ||
| - [Node.js 20 or later](https://nodejs.org/en/) | ||
|
|
||
| ## Run the project |
There was a problem hiding this comment.
тут є команда npm start, але такої у нас уже нема в проєкті
There was a problem hiding this comment.
оновила, щоб було start, як і в усіх інших проєктах
| This repository contains sample ES6 and TypeScript projects that show how to integrate [WebDataRocks](https://www.webdatarocks.com/) with the [React framework](https://react.dev/). | ||
| [](https://www.webdatarocks.com?r=rm_react) | ||
|
|
||
| This repository contains sample ES6 and TypeScript projects that show how to integrate [WebDataRocks](https://www.webdatarocks.com?r=rm_react) with the [React framework](https://react.dev/). | ||
|
|
||
| ## Prerequisites |
There was a problem hiding this comment.
тут для es6 та ts однакові вимоги, може змерджимо?
|
|
||
| ## Prerequisites | ||
|
|
||
| - [Node.js 8 or later](https://nodejs.org/en/) | ||
| - [Node.js 20 or later](https://nodejs.org/en/) | ||
|
|
||
| ## Run the project |
There was a problem hiding this comment.
тут теж команди npm start нема
typescript/index.html
Outdated
| <meta charset="UTF-8" /> | ||
| <link rel="icon" type="image/svg+xml" href="/vite.svg" /> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1.0" /> | ||
| <title>WebDataRocks React TS</title> |
There was a problem hiding this comment.
TypeScript повністю написати мо'?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.