Skip to content

Swagger Description inside Param extension for Security #1179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 46 commits into
base: master
Choose a base branch
from

Conversation

seran
Copy link
Contributor

@seran seran commented Feb 25, 2025

No description provided.

@seran seran changed the title RestCallAction extension for Security Swagger Description inside Param extension for Security Feb 27, 2025
@seran seran marked this pull request as ready for review March 31, 2025 08:06
@seran seran requested a review from arcuri82 March 31, 2025 08:06
@arcuri82
Copy link
Collaborator

arcuri82 commented Apr 7, 2025

@seran hi, should I review this PR, or are u still working on it?

@seran
Copy link
Contributor Author

seran commented Apr 7, 2025

@seran hi, should I review this PR, or are u still working on it?

hi @arcuri82, I made a last minute change. I'll send you a PR review request once the CI is completed

@seran seran requested review from arcuri82 and removed request for arcuri82 May 13, 2025 20:32
/*
a path is inside a Disruptive Gene, because there are cases in which we want to prevent
mutation. Note that 1.0 means can always be mutated
*/
"path" -> params.add(PathParam(name, CustomMutationRateGene("d_", gene, 1.0)))
"header" -> params.add(HeaderParam(name, gene))
"header" -> params.add(HeaderParam(name, gene).apply { this.description = description })
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't this apply to all kinds of param? so could have the apply outside of the when

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are directly add the Param to the MutableList. So I added the description directly to other types also.

@seran seran requested a review from arcuri82 May 19, 2025 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants