Skip to content

Move and share shell TextEncoder/TextDecoder polyfill - #173

Merged
danleh merged 2 commits into
WebKit:mainfrom
danleh:text-decoder-polyfill-move
Sep 3, 2025
Merged

danleh merged 2 commits into
WebKit:mainfrom
danleh:text-decoder-polyfill-move

Conversation

@danleh

@danleh danleh commented Sep 2, 2025

Copy link
Copy Markdown
Contributor

Just to reduce some redundancy, and might also be useful for #170 (where another TextDecoder polyfill was about to be added.)

@netlify

netlify Bot commented Sep 2, 2025 •

Copy link
Copy Markdown

✅ Deploy Preview for webkit-jetstream-preview ready!

Name Link
🔨 Latest commit c947f73
🔍 Latest deploy log https://app.netlify.com/projects/webkit-jetstream-preview/deploys/68b6cab8fcef2d00088ceb43
😎 Deploy Preview https://deploy-preview-173--webkit-jetstream-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@danleh
danleh force-pushed the text-decoder-polyfill-move branch from 7f080a0 to 78eea34 Compare September 2, 2025 00:25
@danleh danleh changed the title Move and share TextEncoder/TextDecoder polyfill Move and share shell TextEncoder/TextDecoder polyfill Sep 2, 2025
@camillobruni

Copy link
Copy Markdown
Contributor

Ok, a bit nit-picky: instead of polyfills/fast-text-encoding-1.0.3/text.js could we use polyfills/fast-text-encoding/1.0.3/text.js and put all package meta information in polyfills/fast-text-encoding?

Comment thread polyfills/README.md Outdated
@danleh

danleh commented Sep 2, 2025 •

Copy link
Copy Markdown
Contributor Author

I'm not sure why jsc/Safari are failing on CI, it does not locally on my x64 Linux machine.

The log at https://github.com/WebKit/JetStream/actions/runs/17401099724/job/49401838880?pr=173#step:8:39 seems to already have an error when jsvu installs and smoke-tests jsc

Testing…
  ✖ Error: Command failed with exit code 133 (Unknown system error -133): /Users/runner/.jsvu/bin/javascriptcore /private/var/folders/x7/ch5v91h56_zbvbd1y2f600dm0000gn/T/b478ccbb75b5498d84ea113a99050011

@kmiller68 can you reproduce or would know what this could be?

Edit: Since #172 CI fails with jsc with the same error (https://github.com/WebKit/JetStream/actions/runs/17403780714/job/49402823507?pr=172), and that doesn't even change any code that is run during testing, this looks like an error on JSC side.

@danleh

danleh commented Sep 3, 2025

Copy link
Copy Markdown
Contributor Author

JSC seems to be fine again, and Safari CI is failing since multiple weeks, so merging.

@danleh
danleh merged commit f121640 into WebKit:main Sep 3, 2025
20 of 27 checks passed
@danleh
danleh deleted the text-decoder-polyfill-move branch September 3, 2025 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants