-
Notifications
You must be signed in to change notification settings - Fork 17
render non default params #197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for webkit-jetstream-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not quite sure what the issue is, but when I run the preview with e.g. ?testList=zlib-wasm
(https://deploy-preview-197--webkit-jetstream-preview.netlify.app/?testList=zlib-wasm), I get the "Non-standard Parameters" warning and red background, but all tests are run and the value of testList
is not shown.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but with some questions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, LGTM too. We could change the color of the button as @danleh mentioned but I'm open.
With non-default params: