Repository navigation
CLI summary label is clearer as Overall instead of Total - #216
Merged
Merged
Conversation
Right now the CLI summary reports its metrics as "Total". I assumed at first glace this meant sum of all the categories. Since that's what the "Total-time" metric is reporting. If the label was "Overall", I think this would be more obvious. The last "Total Time" is now "Overall Wall-Time" to be more consistent with the line items' equivalent report. I also reordered the line item "Total-time" to be before "Wall-Time" because I find that to be a slightly more intuitive order. Before this change: ``` Running 8bitbench-wasm: 8bitbench-wasm First-Score 23.66 pts 8bitbench-wasm Worst-Score 31.79 pts 8bitbench-wasm Average-Score 32.19 pts 8bitbench-wasm Score 28.93 pts 8bitbench-wasm First-Time 211.36 ms 8bitbench-wasm Worst-Time 157.26 ms 8bitbench-wasm Average-Time 155.35 ms 8bitbench-wasm Wall-Time 2390.92 ms 8bitbench-wasm Total-Time 523.97 ms Total: Total First-Score 164.07 pts Total Worst-Score 306.75 pts Total Average-Score 427.19 pts Total Stdlib-Score 13.10 pts Total MainRun-Score 2.89 pts Total First-Time 31.58 ms Total Worst-Time 16.97 ms Total Average-Time 12.16 ms Total Stdlib-Time 381.82 ms Total MainRun-Time 1732.12 ms Total Score 254.28 pts Total Time 93008.80 ms ``` After: ``` Running 8bitbench-wasm: 8bitbench-wasm First-Score 23.14 pts 8bitbench-wasm Worst-Score 31.58 pts 8bitbench-wasm Average-Score 32.05 pts 8bitbench-wasm Score 28.61 pts 8bitbench-wasm First-Time 216.06 ms 8bitbench-wasm Worst-Time 158.35 ms 8bitbench-wasm Average-Time 155.98 ms 8bitbench-wasm Total-Time 530.39 ms 8bitbench-wasm Wall-Time 2404.08 ms Overall: Overall First-Score 171.40 pts Overall Worst-Score 330.65 pts Overall Average-Score 444.21 pts Overall Stdlib-Score 16.04 pts Overall MainRun-Score 2.80 pts Overall First-Time 30.24 ms Overall Worst-Time 15.70 ms Overall Average-Time 11.68 ms Overall Stdlib-Time 311.64 ms Overall MainRun-Time 1785.38 ms Overall Score 268.03 pts Overall Wall-Time 87146.46 ms ```
✅ Deploy Preview for webkit-jetstream-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
Author
|
I didn't change the |
Contributor
|
This will require some gymnastics on our internal CQ to keep the labels stable – but I like the change. Total was always confusing. |
camillobruni
approved these changes
Oct 22, 2025
Contributor
Author
|
Ah, is there a reason you parse the stdout rather than the simple JSON output? |
Contributor
|
our infra settled on manual stdout parsing since that was originally more convenient with all the different runners 🤷 . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now the CLI summary reports its metrics as "Total". I assumed at first glace this meant sum of all the categories. Since that's what the "Total-time" metric is reporting. If the label was "Overall", I think this would be more obvious. The last "Total Time" is now "Overall Wall-Time" to be more consistent with the line items' equivalent report.
I also reordered the line item "Total-time" to be before "Wall-Time" because I find that to be a slightly more intuitive order.
Before this change:
After: