Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you manually edit this? This is an output file from
build.sh
normally so next time someone updates they'll see the old log again.Is there a build with the bits you're uploading here saved somewhere? Maybe we can update that script to pull from there?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This particular line is the abbreviated commit hash and commit message. See hash & commit message from mkustermann/wasm_gc_benchmarks@f80892d
That being said I removed one line from the generated
build log
:git clone
outputed something that's to be interpreted by a terminal rather than normal text (git clone
shows thisUpdating ... (x/y)
where it constantly updates the x/y information of the same line). It wasn't there in the oldbuild.log
and isn't normal text, so I removed that line