Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dart flute WasmGC workload #53

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Dart/build.log
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
Built on 2025-01-28 15:34:10+01:00
Built on 2025-03-06 09:52:17+01:00
Cloning into 'wasm_gc_benchmarks'...
cf32ca4 Recompile all benchmarks
f80892d Update Dart SDK, switch wasm to -O2, recompile performance benchmarks
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you manually edit this? This is an output file from build.sh normally so next time someone updates they'll see the old log again.

Is there a build with the bits you're uploading here saved somewhere? Maybe we can update that script to pull from there?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This particular line is the abbreviated commit hash and commit message. See hash & commit message from mkustermann/wasm_gc_benchmarks@f80892d

That being said I removed one line from the generated build log: git clone outputed something that's to be interpreted by a terminal rather than normal text (git clone shows this Updating ... (x/y) where it constantly updates the x/y information of the same line). It wasn't there in the old build.log and isn't normal text, so I removed that line

Copying files from wasm_gc_benchmarks/ into build/
Build success
Loading