-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Dart flute WasmGC workload #53
Open
mkustermann
wants to merge
1
commit into
WebKit:main
Choose a base branch
from
mkustermann:js-strings
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
Built on 2025-01-28 15:34:10+01:00 | ||
Built on 2025-03-06 09:52:17+01:00 | ||
Cloning into 'wasm_gc_benchmarks'... | ||
cf32ca4 Recompile all benchmarks | ||
f80892d Update Dart SDK, switch wasm to -O2, recompile performance benchmarks | ||
Copying files from wasm_gc_benchmarks/ into build/ | ||
Build success |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you manually edit this? This is an output file from
build.sh
normally so next time someone updates they'll see the old log again.Is there a build with the bits you're uploading here saved somewhere? Maybe we can update that script to pull from there?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This particular line is the abbreviated commit hash and commit message. See hash & commit message from mkustermann/wasm_gc_benchmarks@f80892d
That being said I removed one line from the generated
build log
:git clone
outputed something that's to be interpreted by a terminal rather than normal text (git clone
shows thisUpdating ... (x/y)
where it constantly updates the x/y information of the same line). It wasn't there in the oldbuild.log
and isn't normal text, so I removed that line