Add three.js benchmark #75
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for webkit-jetstream-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
camillobruni
reviewed
Jul 2, 2025
| const canvas = {} | ||
| canvas.addEventListener = function() { } | ||
| canvas.style = {} | ||
| canvas.getContext = function(kind) { |
There was a problem hiding this comment.
nit: I'd probably define the mock-canvas as object literal:
const canvas = {
addEventListener() {},
...
}
camillobruni
reviewed
Jul 2, 2025
| for(let i = 0; i < NUM_PARTICLES; i++) { | ||
| const size = 10 + Math.random() * 80; | ||
| const particle = | ||
| createGeometryParticle(size); |
There was a problem hiding this comment.
nit: superfluous newline
camillobruni
reviewed
Jul 2, 2025
|
|
||
| // Initialize particles | ||
| const particles = []; | ||
| for(let i = 0; i < NUM_PARTICLES; i++) { |
There was a problem hiding this comment.
Could we put this in the init() method?
This might be nice in the future for getting some extra coverage if we add timers.
|
Generally LGTM. Would it make sense to bump to the latest threejs version as well? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.