Skip to content

Use subScores directly for the UI #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 15, 2025

Conversation

camillobruni
Copy link
Contributor

This is a first step to work towards just relying on the subscores() data to populate the UI

  • Use subScores object to prepare the UI
  • delete scoreDescription() since its no longer needed

Copy link

netlify bot commented Jul 1, 2025

Deploy Preview for webkit-jetstream-preview ready!

Name Link
🔨 Latest commit 2a6024b
🔍 Latest deploy log https://app.netlify.com/projects/webkit-jetstream-preview/deploys/6874f6272d175400080d56f9
😎 Deploy Preview https://deploy-preview-81--webkit-jetstream-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@camillobruni camillobruni requested a review from kmiller68 July 1, 2025 15:58
Copy link
Contributor

@danleh danleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with optional further cleanup.

@camillobruni camillobruni merged commit 3bfe58c into WebKit:main Jul 15, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants