Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created tests for donations #746

Merged
merged 1 commit into from
Jun 30, 2023
Merged

Created tests for donations #746

merged 1 commit into from
Jun 30, 2023

Conversation

alhcomer
Copy link
Contributor

@alhcomer alhcomer commented Jun 30, 2023

Closes #683
Sorry for the delay creating a PR, I had some trouble with this task.

I am not 100% sure about testing that the the request was successful in the method 'test_serve_with_post_with_invalid_data' is correct, but I think the rest is OK.

Thanks :)

@sonarcloud
Copy link

sonarcloud bot commented Jun 30, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 6 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codeclimate
Copy link

codeclimate bot commented Jun 30, 2023

Code Climate has analyzed commit 8bea56f and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 69.2% (0.7% change).

View more on Code Climate.

@codecov
Copy link

codecov bot commented Jun 30, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.86 🎉

Comparison is base (e143ac9) 68.33% compared to head (8bea56f) 69.20%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #746      +/-   ##
==========================================
+ Coverage   68.33%   69.20%   +0.86%     
==========================================
  Files         100      101       +1     
  Lines        2994     3023      +29     
==========================================
+ Hits         2046     2092      +46     
+ Misses        948      931      -17     

see 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@brylie brylie merged commit b8c03d1 into WesternFriend:main Jun 30, 2023
@brylie
Copy link
Member

brylie commented Jun 30, 2023

@all-contributors please add @alhcomer for test, code

@allcontributors
Copy link
Contributor

@brylie

@alhcomer already contributed before to test, code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

improve test coverage for donations app
2 participants