Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor payments #752

Merged
merged 8 commits into from
Jul 3, 2023
Merged

Refactor payments #752

merged 8 commits into from
Jul 3, 2023

Conversation

brylie
Copy link
Member

@brylie brylie commented Jul 3, 2023

Closes #750
Closes #690

  • 2023-07-02: 3
  • 2023-07-03: 3

payment/views.py Show resolved Hide resolved
payment/views.py Show resolved Hide resolved
payment/views.py Show resolved Hide resolved
payment/views.py Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jul 3, 2023

Codecov Report

Patch coverage: 92.19% and project coverage change: +1.99 🎉

Comparison is base (bb50ffe) 68.91% compared to head (36163a1) 70.91%.

❗ Current head 36163a1 differs from pull request most recent head b965ec5. Consider uploading reports for the commit b965ec5 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #752      +/-   ##
==========================================
+ Coverage   68.91%   70.91%   +1.99%     
==========================================
  Files         101      100       -1     
  Lines        3066     3067       +1     
==========================================
+ Hits         2113     2175      +62     
+ Misses        953      892      -61     
Impacted Files Coverage Δ
payment/urls.py 100.00% <ø> (ø)
orders/views.py 28.57% <50.00%> (+3.57%) ⬆️
subscription/models.py 64.00% <82.35%> (+1.11%) ⬆️
orders/models.py 74.46% <93.75%> (+0.55%) ⬆️
donations/models.py 98.36% <94.11%> (-1.64%) ⬇️
payment/views.py 96.47% <97.18%> (+76.21%) ⬆️
accounts/models.py 100.00% <100.00%> (ø)
subscription/views.py 83.78% <100.00%> (+0.92%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sonarcloud
Copy link

sonarcloud bot commented Jul 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 13 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codeclimate
Copy link

codeclimate bot commented Jul 3, 2023

Code Climate has analyzed commit b965ec5 and detected 4 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 4

The test coverage on the diff in this pull request is 92.8% (50% is the threshold).

This pull request will bring the total coverage in the repository to 70.9% (2.0% change).

View more on Code Climate.

@brylie brylie merged commit 09e98a9 into main Jul 3, 2023
@brylie brylie deleted the fix-subscription-bug branch July 3, 2023 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New subscription creating two subscription instances improve test coverage for payment app
1 participant