Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bookstore importer and test coverage #758

Merged
merged 20 commits into from
Jul 5, 2023

Conversation

brylie
Copy link
Member

@brylie brylie commented Jul 5, 2023

No description provided.

@codecov
Copy link

codecov bot commented Jul 5, 2023

Codecov Report

Patch coverage: 97.26% and project coverage change: +0.64 🎉

Comparison is base (3a62849) 71.13% compared to head (01cfaa7) 71.77%.

❗ Current head 01cfaa7 differs from pull request most recent head 1f4d10e. Consider uploading reports for the commit 1f4d10e to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #758      +/-   ##
==========================================
+ Coverage   71.13%   71.77%   +0.64%     
==========================================
  Files         100      101       +1     
  Lines        3076     3132      +56     
==========================================
+ Hits         2188     2248      +60     
+ Misses        888      884       -4     
Impacted Files Coverage Δ
content_migration/management/constants.py 100.00% <ø> (ø)
content_migration/management/shared.py 92.00% <94.44%> (+2.14%) ⬆️
content_migration/models.py 100.00% <100.00%> (ø)
store/models.py 83.72% <100.00%> (+0.79%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sonarcloud
Copy link

sonarcloud bot commented Jul 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codeclimate
Copy link

codeclimate bot commented Jul 5, 2023

Code Climate has analyzed commit 1f4d10e and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 97.2% (50% is the threshold).

This pull request will bring the total coverage in the repository to 71.7% (0.6% change).

View more on Code Climate.

@brylie brylie merged commit 2aeb795 into main Jul 5, 2023
3 checks passed
@brylie brylie deleted the bookstore-importer-and-test-coverage branch July 5, 2023 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant