Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cart views tests #764

Merged
merged 14 commits into from
Jul 7, 2023
Merged

Add cart views tests #764

merged 14 commits into from
Jul 7, 2023

Conversation

brylie
Copy link
Member

@brylie brylie commented Jul 7, 2023

No description provided.

product_index_page.add_child(instance=self.product1)
product_index_page.add_child(instance=self.product2)

def test_cart_detail_view(self) -> None:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function test_cart_detail_view has 29 lines of code (exceeds 25 allowed). Consider refactoring.

@codecov
Copy link

codecov bot commented Jul 7, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.70 🎉

Comparison is base (49ffc57) 72.61% compared to head (aa1edac) 73.32%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #764      +/-   ##
==========================================
+ Coverage   72.61%   73.32%   +0.70%     
==========================================
  Files         101      102       +1     
  Lines        3133     3145      +12     
==========================================
+ Hits         2275     2306      +31     
+ Misses        858      839      -19     
Impacted Files Coverage Δ
cart/forms.py 100.00% <ø> (ø)
cart/cart.py 94.44% <100.00%> (+6.51%) ⬆️
cart/views.py 100.00% <100.00%> (+62.50%) ⬆️
store/factories.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sonarcloud
Copy link

sonarcloud bot commented Jul 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codeclimate
Copy link

codeclimate bot commented Jul 7, 2023

Code Climate has analyzed commit aa1edac and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 1

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 73.3% (0.7% change).

View more on Code Climate.

@brylie brylie marked this pull request as ready for review July 7, 2023 14:46
@brylie brylie merged commit 3c3416e into main Jul 7, 2023
3 checks passed
@brylie brylie deleted the add-cart-views-tests branch July 7, 2023 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant