Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Magazine tests continued #783

Merged
merged 26 commits into from
Jul 18, 2023
Merged

Magazine tests continued #783

merged 26 commits into from
Jul 18, 2023

Conversation

brylie
Copy link
Member

@brylie brylie commented Jul 16, 2023

Time

  • 2023-07-16: 1
  • 2023-07-18: 1

@codecov
Copy link

codecov bot commented Jul 16, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +1.61 🎉

Comparison is base (90f102e) 75.93% compared to head (e5a4045) 77.55%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #783      +/-   ##
==========================================
+ Coverage   75.93%   77.55%   +1.61%     
==========================================
  Files         103      101       -2     
  Lines        3196     3061     -135     
==========================================
- Hits         2427     2374      -53     
+ Misses        769      687      -82     
Impacted Files Coverage Δ
magazine/panels.py 100.00% <ø> (ø)
magazine/wagtail_hooks.py 100.00% <ø> (+32.53%) ⬆️
accounts/managers.py 100.00% <100.00%> (+15.00%) ⬆️
magazine/models.py 100.00% <100.00%> (+21.73%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sonarcloud
Copy link

sonarcloud bot commented Jul 18, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 9 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codeclimate
Copy link

codeclimate bot commented Jul 18, 2023

Code Climate has analyzed commit e5a4045 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 77.5% (1.5% change).

View more on Code Climate.

@brylie brylie merged commit b3e8a94 into main Jul 18, 2023
@brylie brylie deleted the magazine-tests-continued branch July 18, 2023 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant