Resolve DB lookup race condition & fix compilation (bump Gradle, license validation), & other misc. improvements/fixes#496
Merged
Conversation
…nse validation), & other misc. improvements/fixes
Contributor
Author
|
Hey @WiIIiam278, everything here okay? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains a variety of changes/improvements on top of what is already defined.
mavenLocal(), for example, was causing compilation failures since it was attempting to read from my cache. This can be confusing and/or cause problems for people who are newly importing HuskClaims.Other than that, the remaining changes were extremely minimal, to sync codestyle and eliminate warnings across the board.
Since this is a bigger set of changes, let me know if anything needs adjusting!
Note: This DOES fix a critical issue with the commands defined via the comments!