Skip to content

feat: add persistent metadata map to claims#498

Merged
WiIIiam278 merged 2 commits into
WiIIiam278:masterfrom
bennycallanan:feat-add-persistent-metadata-map-to-claims
Jul 7, 2026
Merged

feat: add persistent metadata map to claims#498
WiIIiam278 merged 2 commits into
WiIIiam278:masterfrom
bennycallanan:feat-add-persistent-metadata-map-to-claims

Conversation

@bennycallanan

Copy link
Copy Markdown
Contributor

Summary

Adds a per-claim metadata store so third-party plugins can attach persistent key-value data directly to claims.

Changes

  • Adds metadata (Map<String, String>) to Claim
  • Adds getClaimMetadata() and setClaimMetadata() to HuskClaimsAPI

@WiIIiam278 WiIIiam278 left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, sure. I do see one pitfall with this which is that child claims won’t contain their parents metadata, which could confuse plugin authors.

Could you update the API docs for claims on this before I approve?

@bennycallanan

Copy link
Copy Markdown
Contributor Author

Ok, sure. I do see one pitfall with this which is that child claims won’t contain their parents metadata, which could confuse plugin authors.

Could you update the API docs for claims on this before I approve?

For most use cases; I don't think the child claim would need the metadata but if it did it could just use #getParent()?

@WiIIiam278

Copy link
Copy Markdown
Owner

Thank you for contributing to HuskClaims!

@WiIIiam278 WiIIiam278 merged commit 8c38b66 into WiIIiam278:master Jul 7, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants