Skip to content

fix(frontend): restore markdown list markers - #225

Merged
stefan-ernst merged 2 commits into
Windshiftapp:mainfrom
codekoala:fix/safe-markdown-list-markers
Aug 28, 2026
Merged

fix(frontend): restore markdown list markers#225
stefan-ernst merged 2 commits into
Windshiftapp:mainfrom
codekoala:fix/safe-markdown-list-markers

Conversation

@codekoala

Copy link
Copy Markdown
Contributor

What changed

Restores visible list markers for Markdown rendered through SafeMarkdown.

SafeMarkdown already preserved spacing/indentation for ul and ol, but Tailwind/global reset styles could leave read-only Markdown lists without visible bullets or numbers. This adds explicit list marker styles for unordered and ordered lists, and ensures li elements render as list items.

Why

Work item descriptions and comments can contain Markdown bullet or numbered lists. In read-only mode, those lists were rendered with indentation but without markers, while the editor view still showed them correctly. This made existing Markdown content look like plain indented text outside edit mode.

This appears to be a regression from b0068620 (Preserve work item Markdown at render boundaries), which introduced SafeMarkdown for read-only Markdown rendering in 0.8.7. That change preserved sanitized Markdown output, but the new read-only renderer did not explicitly restore list marker styles after the global reset, so bullets/numbers disappeared outside edit mode.

Testing

  • npm run check
  • Verified locally in a deployed Windshift instance with bullet lists in both a work item description and comment.

Screenshots

Work item description and comment containing bullet points:

image

Same work item when editing the description and comment:

image

Same work item with this fix applied:

image

@github-actions

github-actions Bot commented Aug 28, 2026

Copy link
Copy Markdown

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@codekoala

Copy link
Copy Markdown
Contributor Author

I have read the CLA Document and I hereby sign the CLA

github-actions Bot added a commit that referenced this pull request Aug 28, 2026
@stefan-ernst

Copy link
Copy Markdown
Contributor

Thanks a lot for your contribution!

One minor issue, we need to exclude the Checkboxes, otherwise the Checklist will have - [x] styling

I would suggest this exclusion:

.safe-markdown :global(li:has(> input[type='checkbox']:first-child)), .safe-markdown :global(li:has(> p:first-child > input[type='checkbox']:first-child)) { list-style-type: none; }

@stefan-ernst

Copy link
Copy Markdown
Contributor

Excellent - merging this

@stefan-ernst
stefan-ernst merged commit 5b5b358 into Windshiftapp:main Aug 28, 2026
2 checks passed
@codekoala

Copy link
Copy Markdown
Contributor Author

Thank you very much!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants