fix(frontend): isolate sidebar scrolling across the app - #235
Conversation
9749601 to
ce3c72c
Compare
|
Follow-up improvements added in
Verified with:
Also checked both sidebar states in the local Vite app. |
|
Hey @oshuej198 thank you! Currently verifying this. Minor issue I noticed:
The missing shortcut help on the right creates a visual gap here |
|
Thanks for the feedback! I found the actual root cause of the delayed sidebar items.
|
|
This PR has merge conflicts that need to be resolved before it can be merged. Please rebase on the latest |
| class="flex items-center justify-start px-4 w-full h-10 mb-2 hover:opacity-80 transition-opacity cursor-pointer" | ||
| > | ||
| <img src="windshift-3.svg" alt="Windshift" class="w-8 h-8 flex-shrink-0" /> | ||
| <img src="/windshift-3.svg" alt="Windshift" class="w-8 h-8 flex-shrink-0" /> |
There was a problem hiding this comment.
this causes context paths not to work, I would just leave the relative src here
There was a problem hiding this comment.
You're right — thanks for pointing this out. The relative path was broken for me only in the local Vite dev server on nested routes (which is visible in the earlier screenshots), so I changed it while fixing the local sidebar. Production does inject a <base> element, so the relative asset path resolves correctly there and also preserves context-path deployments. I overlooked that distinction. I'll restore the relative src; the local dev-server base-path mismatch should be handled separately rather than with a root-relative URL.
There was a problem hiding this comment.
Fixed in 54f355b2.
You’re right — the leading slash was accidental and slipped into the broader sidebar refactoring commit.
The relative URL appeared broken locally on nested routes because the Vite dev server does not inject the production element. In production, the Go server injects the correct base URL, including the configured context path.
I’ve restored src="windshift-3.svg". Thanks for catching this!
|
I think all the overflow-hidden on the main content areas have to be replaced, it cuts off everything that needs to grow vertically, for example a long milestone list, iteration list etc |






Closes #224
What changed
ScrollableSidebarandNavigationSidebarprimitives with fixed header/footer regions and independent content scrollingAdditional improvements beyond #224
While validating the shared layout, the main application sidebar received a broader UX pass:
CkeyVerification
npm run typechecknpm run checknpx vitest run— 35 tests passednpm run buildCoverage
The shared layout contract now covers expanded and collapsed main navigation, global and workspace navigation variants, independently scrolling content panes, and short-content sidebars.