Change enableFootnotes site param to be a page-level param#90
Closed
krisbalintona wants to merge 3 commits intomainfrom
Closed
Change enableFootnotes site param to be a page-level param#90krisbalintona wants to merge 3 commits intomainfrom
krisbalintona wants to merge 3 commits intomainfrom
Conversation
Author
|
Oops! I made a mistake in submitting this. I submitted a request properly at #91. Sorry! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that floating footnotes (set by the variable
enableFootnotes) is determined by the site parameter, while changing the variable per-page does not have an effect.This pull request loosens the restriction of having the site-level variable be used. In other words, setting
enableFootnotes = falsehas an effect when
enableFootnotesistrueat the site level.Cheers!