Create listing details header #334
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rashidovasadbek
changed the title
sulton-max
requested changes
Feb 22, 2024
Comment on lines
+35
to
+42
| public async ValueTask<IActionResult> GetListingById([FromRoute]Guid listingId, | ||
| CancellationToken cancellationToken = default) | ||
| { | ||
| var result = await listingService.GetByIdAsync(listingId, true, cancellationToken); | ||
| var result = await listingRepository | ||
| .Get(asNoTracking: true) | ||
| .Include(listing => listing.ImagesStorageFile) | ||
| .ThenInclude(media => media.StorageFile) | ||
| .FirstOrDefaultAsync(listing => listing.Id == listingId); |
There was a problem hiding this comment.
Create GetListingByIdQuery and query handler and move all include logic there
| @@ -1,6 +1,6 @@ | |||
| <template> | |||
|
|
|||
| <button class="rounded-full theme-border theme-bg-primary primary-transition"> | |||
| <button name="PreviousButton" class="rounded-full theme-border theme-bg-primary primary-transition"> | |||
There was a problem hiding this comment.
Shouldn't it be NextButton instead ?
Comment on lines
+99
to
+100
| console.log(event.target); | ||
| console.log('carousel', carousel); |
There was a problem hiding this comment.
Remove console logging
| @@ -82,7 +82,7 @@ const loadListingsAsync = async () => { | |||
| const response = await airBnbApiClient.listings.getAsync(selectedCategoryId.value, listingsPagination.value); | |||
|
|
|||
| if (response.response) { | |||
| listings.value.push(...response.response); | |||
| listings.value.push(...response.response) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #239