-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Components: Remove "experimental" designation for CustomSelectControlV2
#61078
Components: Remove "experimental" designation for CustomSelectControlV2
#61078
Conversation
Note to self: follow-up this (or work in parallel) with a PR to change the default exported implementation to the new legacy adapter from V2. I started playing with it in this commit: 752a07f, and found some API problems with the new adapter. |
packages/components/src/custom-select-control-v2/stories/legacy.story.tsx
Show resolved
Hide resolved
CustomSelectControlV2
CustomSelectControlV2
CustomSelectControlV2
CustomSelectControlV2
CustomSelectControlV2
CustomSelectControlV2
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
1c1b77e
to
b1e29b4
Compare
b1e29b4
to
82d2af9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we also remove the experimental callout from the component README?
This feature is still experimental. “Experimental” means this is an early implementation subject to drastic and breaking changes. |
Otherwise, looks good to me 👍
Issue: #59418.
What?
This is part of a larger effort to remove
__experimental
prefix from all "experimental" components, effectively promoting them to regular stable components. See the related issue for more context.Why?
The strategy of prefixing exports with
__experimental
has become deprecated after the introduction of private APIs.How?
__experimental
prefix;__experimental
export for backwards compatibility;__experimental
in GB and components to the one without the prefix (including in storybook stories). Also, update the docs to refer to the new unprefixed component;id
(get it from the storybook URL) to thePREVIOUSLY_EXPERIMENTAL_COMPONENTS
const array inmanager-head.html
so that old experimental story paths are redirected to the new one;