Navigator: use stable export instead of experimental export #65753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 tasks
|
Size Change: +499 B (+0.03%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
ciampo
force-pushed
the
feat/navigator-replace-experimental-usage
branch
from
4806ee3
to
dfbc26b
Compare
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
ciampo
added
[Type] Code Quality
mirka
reviewed
Sep 30, 2024
There was a problem hiding this comment.
Only tangential, but I found it a bit misleading that there is no separate legacy implementation of useNavigator, but it's exported from the legacy folder. For clarity, maybe export it directly from the current implementation folder?
diff --git a/packages/components/src/index.ts b/packages/components/src/index.ts
index cc3c0265c4..1d0e1dd839 100644
--- a/packages/components/src/index.ts
+++ b/packages/components/src/index.ts
@@ -130,9 +130,13 @@ export {
NavigatorButton as __experimentalNavigatorButton,
NavigatorBackButton as __experimentalNavigatorBackButton,
NavigatorToParentButton as __experimentalNavigatorToParentButton,
- useNavigator as __experimentalUseNavigator,
} from './navigator/legacy';
-export { Navigator, useNavigator } from './navigator';
+export {
+ Navigator,
+ useNavigator,
+ /** @deprecated Import `useNavigator` instead. */
+ useNavigator as __experimentalUseNavigator,
+} from './navigator';
export { default as Notice } from './notice';
export { default as __experimentalNumberControl } from './number-control';
export { default as NoticeList } from './notice/list';
packages/block-editor/src/components/inserter/mobile-tab-navigation.js
Outdated
Show resolved
Hide resolved
packages/edit-site/src/components/global-styles/font-library-modal/installed-fonts.js
Outdated
Show resolved
Hide resolved
ciampo
force-pushed
the
feat/navigator-replace-experimental-usage
branch
from
dfbc26b
to
b28a122
Compare
ciampo
commented
Sep 30, 2024
| export { | ||
| Navigator, | ||
| useNavigator, | ||
| useNavigator as __experimentalUseNavigator, |
There was a problem hiding this comment.
The deprecation will happen in a follow-up PR
getdave
pushed a commit
that referenced
this pull request
Oct 1, 2024
* Navigator: use stable export instead of experimental export * More clear export of useNavigator --- Co-authored-by: ciampo <[email protected]> Co-authored-by: mirka <[email protected]>
huubl
pushed a commit
to huubl/gutenberg
that referenced
this pull request
Oct 2, 2024
…s#65753) * Navigator: use stable export instead of experimental export * More clear export of useNavigator --- Co-authored-by: ciampo <[email protected]> Co-authored-by: mirka <[email protected]>
huubl
added a commit
to huubl/gutenberg
that referenced
this pull request
Oct 2, 2024
…ordPress#65753)" This reverts commit 591700a.
draganescu
pushed a commit
that referenced
this pull request
Oct 2, 2024
* Navigator: use stable export instead of experimental export * More clear export of useNavigator --- Co-authored-by: ciampo <[email protected]> Co-authored-by: mirka <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Part of #59418
Refactor existing usages of
Navigatorto use the stable export of the component, instead of the experimental export.Why?
The component had become stable, and the experimental APIs will be deprecated soon.
How?
By refactoring the imports throughout the repository.
Testing Instructions
Smoke test the app, make sure that all places where
Navigatoris used keep working as expected: