-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Speculative Loading WP Core API, loading the plugin's own API implementation conditionally #1883
Open
felixarntz
wants to merge
2
commits into
trunk
Choose a base branch
from
add/speculation-rules-core-api-support
base: trunk
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+282
−113
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
<?php | ||
/** | ||
* Test Bootstrap for Speculative Loading. | ||
* | ||
* @package speculation-rules | ||
*/ | ||
|
||
// Load conditionally loaded files unconditionally so that they can be tested. | ||
require_once TESTS_PLUGIN_DIR . '/class-plsr-url-pattern-prefixer.php'; | ||
require_once TESTS_PLUGIN_DIR . '/plugin-api.php'; | ||
require_once TESTS_PLUGIN_DIR . '/wp-core-api.php'; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
81 changes: 81 additions & 0 deletions
81
plugins/speculation-rules/tests/test-speculation-rules-wp-core-api.php
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,81 @@ | ||
<?php | ||
/** | ||
* Tests for speculation-rules WP Core API. | ||
* | ||
* @package speculation-rules | ||
*/ | ||
|
||
class Test_Speculation_Rules_WP_Core_API extends WP_UnitTestCase { | ||
|
||
public function test_plsr_filter_speculation_rules_configuration_with_regular(): void { | ||
$this->assertSame( | ||
array( | ||
'mode' => 'prerender', | ||
'eagerness' => 'moderate', | ||
), | ||
plsr_filter_speculation_rules_configuration( | ||
array( | ||
'mode' => 'prefetch', | ||
'eagerness' => 'conservative', | ||
) | ||
) | ||
); | ||
} | ||
|
||
public function test_plsr_filter_speculation_rules_configuration_with_invalid(): void { | ||
$this->assertSame( | ||
array( | ||
'mode' => 'prerender', | ||
'eagerness' => 'moderate', | ||
), | ||
plsr_filter_speculation_rules_configuration( 'neither-an-array-nor-null' ) | ||
); | ||
} | ||
|
||
public function test_plsr_filter_speculation_rules_configuration_with_null(): void { | ||
$this->assertNull( plsr_filter_speculation_rules_configuration( null ) ); | ||
} | ||
|
||
public function test_plsr_filter_speculation_rules_configuration_with_pretty_permalinks_filter(): void { | ||
// Providing null while pretty permalinks are disabled should be respected. | ||
$this->disable_pretty_permalinks(); | ||
$this->assertNull( plsr_filter_speculation_rules_configuration( null ) ); | ||
|
||
// Unless the filter to enable speculative loading despite that is set to true. | ||
add_filter( 'plsr_enabled_without_pretty_permalinks', '__return_true' ); | ||
$this->assertSame( | ||
array( | ||
'mode' => 'prerender', | ||
'eagerness' => 'moderate', | ||
), | ||
plsr_filter_speculation_rules_configuration( null ) | ||
); | ||
} | ||
|
||
public function test_plsr_filter_speculation_rules_exclude_paths_with_regular(): void { | ||
$base_rules = array( '/membership-areas/*' ); | ||
|
||
$this->assertSame( $base_rules, plsr_filter_speculation_rules_exclude_paths( $base_rules, 'prefetch' ) ); | ||
|
||
add_filter( | ||
'plsr_speculation_rules_href_exclude_paths', | ||
static function ( $rules ) { | ||
$rules[] = '/cart/*'; | ||
return $rules; | ||
} | ||
); | ||
|
||
$this->assertSame( | ||
array_merge( $base_rules, array( '/cart/*' ) ), | ||
plsr_filter_speculation_rules_exclude_paths( $base_rules, 'prefetch' ) | ||
); | ||
} | ||
|
||
public function test_plsr_filter_speculation_rules_exclude_paths_with_invalid(): void { | ||
$this->assertSame( array( '/personalized/*' ), plsr_filter_speculation_rules_exclude_paths( '/personalized/*', 'prefetch' ) ); | ||
} | ||
|
||
private function disable_pretty_permalinks(): void { | ||
update_option( 'permalink_structure', '' ); | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note for reviewers: This function was moved without any changes to the
plugin-api.php
file.