Update condition for detecting missing headers

WordPress · Feb 7, 2024 · ecc4a54 · ecc4a54
1 parent e2a70be
commit ecc4a54
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/includes/Checker/Checks/Plugin_Readme_Check.php b/includes/Checker/Checks/Plugin_Readme_Check.php
@@ -145,8 +145,10 @@ private function check_headers( Check_Result $result, string $readme_file, Parse
 			),
 		);
 
+		$parser_warnings = $parser->warnings ?? array();
+
 		foreach ( $fields as $field_key => $field ) {
-			if ( empty( $parser->{$field_key} ) && ! in_array( $field['ignore_key'], $ignored_warnings, true ) ) {
+			if ( empty( $parser->{$field_key} ) && ! in_array( $field['ignore_key'], $ignored_warnings, true ) && ! isset( $parser_warnings[ $field['ignore_key'] ] ) ) {
 				$this->add_result_warning_for_file(
 					$result,
 					sprintf(