Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add check in readme for invalid plugin name header #398

Merged
merged 8 commits into from
Jan 31, 2024
Merged

Add check in readme for invalid plugin name header #398

merged 8 commits into from
Jan 31, 2024

Conversation

ernilambar
Copy link
Member

@ernilambar ernilambar commented Jan 23, 2024 •
edited
Loading

Fixes #397

  • Add check for invalid plugin name header in readme.
  • ERROR is raised if plugin name in the readme is invalid.

@ernilambar
Copy link
Member Author

cc: @swissspidy @felixarntz @mukeshpanchal27

@ernilambar ernilambar mentioned this pull request Jan 23, 2024
Merged
@ernilambar
Copy link
Member Author

Unit test is failing because Parser package is not updated in this PR. This PR should be merged after this #395

@swissspidy
Copy link
Member

Unit test is failing because Parser package is not updated in this PR. This PR should be merged after this #395

Can you do the same update in this PR?

@ernilambar
Copy link
Member Author

  • Test case added for empty plugin name.
  • Now Testing is failed because of unset( $warnings['invalid_plugin_name_header'] );. We have done this in another PR. Because we have not removed this item from warnings list, test is failing.

@swissspidy
Copy link
Member

Can we make the same change here so that this doesn't depend on another PR?

@ernilambar ernilambar force-pushed the 397-invalid-plugin-name-header branch from 6f23219 to cad998f Compare January 26, 2024 16:01
@ernilambar ernilambar force-pushed the 397-invalid-plugin-name-header branch from 50f6687 to 8e1a1b8 Compare January 29, 2024 16:31
@ernilambar @mukeshpanchal27
Fix typo in error message
0cb0389 
Co-authored-by: Mukesh Panchal <[email protected]>
@mukeshpanchal27 mukeshpanchal27 merged commit 232fcdd into WordPress:trunk Jan 31, 2024
24 checks passed
@ernilambar ernilambar deleted the 397-invalid-plugin-name-header branch January 31, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swissspidy swissspidy swissspidy approved these changes

@mukeshpanchal27 mukeshpanchal27 mukeshpanchal27 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing invalid plugin name header check in Readme Check
3 participants
@ernilambar @swissspidy @mukeshpanchal27