-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Detect localhost/127.0.0.1 code in multiple files #399
Detect localhost/127.0.0.1 code in multiple files #399
Conversation
5614941
to
2e0d302
Compare
Let's discuss the right approach on the issue first. This applies to other checks as well. |
Thanks for this change, I think that for this check it would be really useful to also give users the line + column where that happens (as well as showing more than one case for file). I mentioned this on #362 . Also, I can suggest to add other common "localhost" cases like:
|
5821136
to
112532b
Compare
112532b
to
3430e85
Compare
PR has been updated based on feedback. |
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Fixes #362
files_preg_match
inAbstract_File_Check
to return multiple results matched with given regex.Localhost_Check
to handle array of resultsLocalhost_Check_Tests
accordingly