Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check for missing Stable Tag in readme #403

Merged
merged 3 commits into from
Feb 5, 2024

Conversation

ernilambar
Copy link
Member

@ernilambar ernilambar commented Jan 25, 2024

  • Update function check_stable_tag() to test if Stable Tag is missing
  • Raise ERROR for missing stable tag
  • Update tests to reflect new changes

Since the value of Stable Tag is very important in our directory, I have kept this check as ERROR. We can keep it as WARNING if otherwise. This check is currently not there in legacy version.

cc: @swissspidy @felixarntz @mukeshpanchal27

@ernilambar ernilambar force-pushed the add-check-no-stable-tag branch from 4fba8a4 to 9eb696b Compare January 25, 2024 05:47
@swissspidy
Copy link
Member

@foosantos @bordoni Is such a check for missing Stable Tag useful for the plugin review team?

@foosantos
Copy link
Member

Yes, that is indeed one of the things that is checked manually, so surely relevant. Thank you, @ernilambar and @swissspidy!

@ernilambar ernilambar force-pushed the add-check-no-stable-tag branch from 3350372 to 47128f2 Compare January 29, 2024 12:09
@mukeshpanchal27 mukeshpanchal27 merged commit 1342fa8 into WordPress:trunk Feb 5, 2024
24 checks passed
@ernilambar ernilambar deleted the add-check-no-stable-tag branch February 5, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants