Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Plugin_Header_Requires_Check #406

Closed
wants to merge 5 commits into from
Closed

Add Plugin_Header_Requires_Check #406

wants to merge 5 commits into from

Conversation

ernilambar
Copy link
Member

Fixes #405

  • Add Plugin_Header_Requires_Check
  • Tests added for Plugin_Header_Requires_Check
  • For single file plugin or plugin without readme file, headers of main plugin is checked. ERROR is raised if no headers found
  • For multi file plugin, ERROR is raised if headers are missing from both main plugin file or readme file

@ernilambar
Copy link
Member Author

cc: @swissspidy @mukeshpanchal27 @felixarntz

@swissspidy
Copy link
Member

Let's discuss on the ticket first.

PS Felix is on leave right now, best not to ping him :)

@ernilambar
Copy link
Member Author

Closing this for now. We can reopen in the future if needed.

@ernilambar ernilambar closed this Jun 11, 2024
@ernilambar ernilambar deleted the 405-requires branch July 12, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Requires related plugin header check in readme
2 participants
@ernilambar @swissspidy