Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature to exclude files in the check #408

Merged
merged 16 commits into from
Jul 3, 2024
Merged

Feature to exclude files in the check #408

merged 16 commits into from
Jul 3, 2024

Conversation

ernilambar
Copy link
Member

@ernilambar ernilambar commented Jan 30, 2024 •
edited
Loading

Fix partially #388

  • --exclude-files argument added in plugin check command
  • Filter wp_plugin_check_ignore_files added for ignoring files
  • Added Behat tests and unit tests

@ernilambar
Copy link
Member Author

cc: @swissspidy @mukeshpanchal27

@ernilambar ernilambar marked this pull request as ready for review January 31, 2024 11:34
@ernilambar
Copy link
Member Author

@mukeshpanchal27 Merge conflict has been fixed.

@ernilambar
Copy link
Member Author

@mukeshpanchal27 PR is synced with trunk and n.e.x.t has been removed as version.

@mukeshpanchal27
Copy link
Member

mukeshpanchal27 commented Apr 22, 2024 •
edited
Loading

@swissspidy Do you know why the Behat test failed?

@swissspidy
Copy link
Member

As the error message says, the codecov token is missing, because this PR is originating from a fork. The tests are passing.

davidperezgar
davidperezgar approved these changes Jul 3, 2024
View reviewed changes
Copy link
Member

@davidperezgar davidperezgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's very nice this enhacement that will solve false positives.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 3, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: ernilambar <[email protected]>
Co-authored-by: mukeshpanchal27 <[email protected]>
Co-authored-by: davidperezgar <[email protected]>
Co-authored-by: swissspidy <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@davidperezgar davidperezgar merged commit c7c428e into WordPress:trunk Jul 3, 2024
19 checks passed
@ernilambar ernilambar mentioned this pull request Jul 4, 2024
Merged
@ernilambar ernilambar deleted the 388-exclude-files branch July 5, 2024 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swissspidy swissspidy swissspidy approved these changes

@mukeshpanchal27 mukeshpanchal27 mukeshpanchal27 left review comments

@davidperezgar davidperezgar davidperezgar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ernilambar @mukeshpanchal27 @swissspidy @davidperezgar