Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix edit file URL for single file plugin #413

Merged
merged 2 commits into from
Feb 5, 2024
Merged

Fix edit file URL for single file plugin #413

merged 2 commits into from
Feb 5, 2024

Conversation

ernilambar
Copy link
Member

Fixes #412

  • Value of file is generated conditionally

@ernilambar
Copy link
Member Author

cc: @swissspidy @mukeshpanchal27

mukeshpanchal27
mukeshpanchal27 approved these changes Feb 5, 2024
View reviewed changes
Copy link
Member

@mukeshpanchal27 mukeshpanchal27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch.

@mukeshpanchal27 mukeshpanchal27 merged commit 1be0e35 into WordPress:trunk Feb 5, 2024
24 checks passed
@ernilambar ernilambar deleted the 412-fix-edit-link branch February 5, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swissspidy swissspidy swissspidy approved these changes

@mukeshpanchal27 mukeshpanchal27 mukeshpanchal27 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect edit link in single file plugin
3 participants
@ernilambar @swissspidy @mukeshpanchal27