Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename main plugin file name to match v0.2.3 #419

Merged
merged 2 commits into from
Feb 9, 2024

Conversation

swissspidy
Copy link
Member

If we change the main plugin filename, the plugin would get deactivated when updating it.

@ernilambar
Copy link
Member

For me, I would not rename it and keep plugin-check/plugin-check.php as it is. This is the standard practices we are spreading about plugin development best practices in our handbook and other documents. I would prefer sticking to the best practices what we are advising for other developers.
Since this plugin is targeted for developers and also active installations is also not that high, and also major versions are generally bound to have breaking changes, may be we can keep appropriate Upgrade Notice in readme and keep files as it is. Just my 2 cents.

@joemcgill
Copy link
Member

I tend to agree with @ernilambar. What if we just added a plugin.php file that updated the value in the DB and then loaded the original plugin-check.php file? That should keep back-compat in place and eventually get everyone on the correct file.

@swissspidy
Copy link
Member Author

The thing with a compat file is that you have to keep it forever, which is a bit unnecessary. It's just a filename, it doesn't really affect anything, and keeping the existing one doesn't hurt anyone.

I just had a quick chat with @bordoni about this and he also prefers not having to deactivate plugins either. Especially since it's already active on WordPress.org as well.

So this simple renaming is the most straightforward way to address this issue.

@swissspidy swissspidy merged commit c82b335 into trunk Feb 9, 2024
24 checks passed
@swissspidy swissspidy deleted the try/rename-plugin-file branch February 9, 2024 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants