Strip tags in CLI output #560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swissspidy
added
the
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
mukeshpanchal27
approved these changes
Aug 2, 2024
| @@ -522,6 +522,7 @@ private function flatten_file_results( $file_errors, $file_warnings ) { | |||
| foreach ( $column_errors as $column_error ) { | |||
|
|
|||
| $column_error['message'] = str_replace( '<br>', "\n", $column_error['message'] ); | |||
| $column_error['message'] = wp_strip_all_tags( $column_error['message'] ); | |||
There was a problem hiding this comment.
Nice!
Table(default) format
FILE: readme.txt
| line | column | type | code | message | docs |
|---|---|---|---|---|---|
| 0 | 0 | ERROR | outdated_tested_upto_header | Tested up to: 6.5 < 6.6. The "Tested up to" value in your plugin is not set to the current version of WordPress. This means your plugin will not show up in searches, as we require plugins to be compatible and documented as tested up to the most recent version of WordPress. | https://developer.wordpress.org/plugins/wordpress-org/how-your-readme-txt-works/#readme-header-information |
Json format
FILE: readme.txt
[{"line":0,"column":0,"type":"ERROR","code":"outdated_tested_upto_header","message":"Tested up to: 6.5 < 6.6.\nThe \"Tested up to\" value in your plugin is not set to the current version of WordPress. This means your plugin will not show up in searches, as we require plugins to be compatible and documented as tested up to the most recent version of WordPress.","docs":"https:\/\/developer.wordpress.org\/plugins\/wordpress-org\/how-your-readme-txt-works\/#readme-header-information"}]
CSV format
``` FILE: readme.txt line,column,type,code,message,docs 0,0,ERROR,outdated_tested_upto_header,"Tested up to: 6.5 < 6.6. The ""Tested up to"" value in your plugin is not set to the current version of WordPress. This means your plugin will not show up in searches, as we require plugins to be compatible and documented as tested up to the most recent version of WordPress.",https://developer.wordpress.org/plugins/wordpress-org/how-your-readme-txt-works/#readme-header-information ```Not blocker: The JSON format didn't remove \n as it will exclude it if we pass second perameter as true in wp_strip_all_tags().
davidperezgar
approved these changes
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #557