Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use untranslated Plugin Name for comparison #765

Merged
merged 3 commits into from
Nov 4, 2024
Merged

Use untranslated Plugin Name for comparison #765

merged 3 commits into from
Nov 4, 2024

Conversation

davidperezgar
Copy link
Member

Fixes #764

@davidperezgar davidperezgar linked an issue Nov 2, 2024 that may be closed by this pull request
Warning when the plugin name in the readme.txt file differs from the plugin header (bug with translations) #764
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 2, 2024 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: davidperezgar <[email protected]>
Co-authored-by: ernilambar <[email protected]>
Co-authored-by: swissspidy <[email protected]>
Co-authored-by: Rod-Gomes <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@davidperezgar davidperezgar self-assigned this Nov 2, 2024
@davidperezgar davidperezgar requested review from swissspidy and felixarntz and removed request for chriscct7, frantorres and barrykooij November 2, 2024 08:52
@davidperezgar
Copy link
Member Author

davidperezgar commented Nov 3, 2024 •
edited
Loading

@ernilambar There are some tests already with the translation of the plugin header.

@ernilambar ernilambar requested a review from frantorres November 4, 2024 06:35
@ernilambar ernilambar added the [Type] Bug An existing feature is broken label Nov 4, 2024
@ernilambar ernilambar added this to the 1.3.0 milestone Nov 4, 2024
@ernilambar ernilambar added the [Team] Plugin Review Issues owned by Plugin Review Team label Nov 4, 2024
@ernilambar ernilambar changed the title Force to not make translatable strings Use untranslated Plugin Name for comparison Nov 4, 2024
@ernilambar ernilambar merged commit b713c7f into trunk Nov 4, 2024
31 checks passed
@ernilambar ernilambar deleted the 764-warning-when-the-plugin-name-in-the-readmetxt-file-differs-from-the-plugin-header-bug-with-translations branch November 4, 2024 09:57
@davidperezgar
Copy link
Member Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swissspidy swissspidy swissspidy approved these changes

@ernilambar ernilambar ernilambar approved these changes

@felixarntz felixarntz Awaiting requested review from felixarntz

@frantorres frantorres Awaiting requested review from frantorres frantorres is a code owner

Assignees

@davidperezgar davidperezgar

Labels
[Team] Plugin Review Issues owned by Plugin Review Team [Type] Bug An existing feature is broken
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.

Warning when the plugin name in the readme.txt file differs from the plugin header (bug with translations)
3 participants
@davidperezgar @swissspidy @ernilambar