Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update exclude rule for WP alternative functions sniff #836

Merged
merged 2 commits into from
Dec 17, 2024
Merged

Update exclude rule for WP alternative functions sniff #836

merged 2 commits into from
Dec 17, 2024

Conversation

ernilambar
Copy link
Member

Fixes #830

@ernilambar ernilambar marked this pull request as ready for review December 17, 2024 03:39
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 17, 2024 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: ernilambar <[email protected]>
Co-authored-by: swissspidy <[email protected]>
Co-authored-by: mukeshpanchal27 <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@ernilambar ernilambar added [Type] Bug An existing feature is broken [Team] Plugin Review Issues owned by Plugin Review Team labels Dec 17, 2024
@ernilambar ernilambar added this to the 1.4.0 milestone Dec 17, 2024
@ernilambar ernilambar merged commit 1f446de into trunk Dec 17, 2024
29 of 30 checks passed
@ernilambar ernilambar deleted the 830-exclude-in-ruleset-not-working-for-json_encode branch December 17, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swissspidy swissspidy swissspidy approved these changes

@mukeshpanchal27 mukeshpanchal27 mukeshpanchal27 approved these changes

@frantorres frantorres Awaiting requested review from frantorres

@davidperezgar davidperezgar Awaiting requested review from davidperezgar

Assignees
No one assigned
Labels
[Team] Plugin Review Issues owned by Plugin Review Team [Type] Bug An existing feature is broken
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.

Exclude in ruleset not working for json_encode()
3 participants
@ernilambar @swissspidy @mukeshpanchal27