Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add include experimental option in admin #874

Merged
merged 6 commits into from
Feb 21, 2025
Merged

Add include experimental option in admin #874

merged 6 commits into from
Feb 21, 2025

Conversation

ernilambar
Copy link
Member

@ernilambar ernilambar commented Feb 17, 2025 •
edited
Loading

Fixes #873

Screenshot:
Screenshot 2025-02-17 at 4 19 08 PM

@ernilambar
Copy link
Member Author

Should we save the state of new checkbox like we are doing for categories?

@swissspidy
Copy link
Member

@ernilambar still a draft?

@ernilambar ernilambar marked this pull request as ready for review February 21, 2025 08:44
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 21, 2025 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: ernilambar <[email protected]>
Co-authored-by: davidperezgar <[email protected]>
Co-authored-by: swissspidy <[email protected]>
Co-authored-by: mukeshpanchal27 <[email protected]>
Co-authored-by: frantorres <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@swissspidy swissspidy added the [Type] Enhancement A suggestion for improvement of an existing feature label Feb 21, 2025
swissspidy
swissspidy reviewed Feb 21, 2025
View reviewed changes
Copy link
Member

@swissspidy swissspidy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok, just a couple of suggestions.

Not really an urgent change as we don't actually have any experimental checks right now.

@ernilambar ernilambar added this to the 1.5.0 milestone Feb 21, 2025
@ernilambar ernilambar merged commit 9905f34 into trunk Feb 21, 2025
28 checks passed
@ernilambar ernilambar deleted the add-experimental-admin-option branch February 21, 2025 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mukeshpanchal27 mukeshpanchal27 mukeshpanchal27 left review comments

@swissspidy swissspidy swissspidy approved these changes

@frantorres frantorres frantorres approved these changes

@davidperezgar davidperezgar Awaiting requested review from davidperezgar

Assignees
No one assigned
Labels
[Type] Enhancement A suggestion for improvement of an existing feature
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.

Add Include Experimental option in admin UI
5 participants
@ernilambar @swissspidy @frantorres @mukeshpanchal27 @davidperezgar