Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure headers are not empty in the requires header check #878

Merged
merged 1 commit into from
Feb 21, 2025

Conversation

ernilambar
Copy link
Member

@ernilambar ernilambar commented Feb 20, 2025

When there is Requires at least is plugin header but not in readme, this check should not have been triggered. It generated message like this.

Mismatched Requires at least:  != 4.9. "Requires at least" needs to be exactly the same with that in your main plugin file's header.

So I believe it makes sense to check for not empty for header value before actually checking the comparison.

@ernilambar ernilambar marked this pull request as ready for review February 20, 2025 09:21
Copy link

github-actions bot commented Feb 20, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: ernilambar <[email protected]>
Co-authored-by: davidperezgar <[email protected]>
Co-authored-by: swissspidy <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@swissspidy
Copy link
Member

Is there a test or at least bug description that explains whag this solves?

@ernilambar
Copy link
Member Author

Description updated.

@ernilambar ernilambar added the [Team] Plugin Review Issues owned by Plugin Review Team label Feb 21, 2025
@ernilambar ernilambar added this to the 1.5.0 milestone Feb 21, 2025
@ernilambar ernilambar added the [Type] Bug An existing feature is broken label Feb 21, 2025
@ernilambar ernilambar merged commit 4cdda05 into trunk Feb 21, 2025
30 checks passed
@ernilambar ernilambar deleted the fix-not-empty-header-check branch February 21, 2025 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Team] Plugin Review Issues owned by Plugin Review Team [Type] Bug An existing feature is broken
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants