Check minor version tested up #886
Conversation
davidperezgar
requested review from
barrykooij,
ernilambar,
frantorres and
chriscct7
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
| @@ -491,8 +509,8 @@ public function test_run_with_errors_tested_up_to_latest_plus_two_version() { | |||
| $filtered_items = wp_list_filter( $errors['readme.md'][0][0], array( 'code' => 'nonexistent_tested_upto_header' ) ); | |||
|
|
|||
| $this->assertCount( 1, $filtered_items ); | |||
| $this->assertStringContainsString( 'Tested up to: 6.1', $filtered_items[0]['message'] ); | |||
| $this->assertStringContainsString( 'This version of WordPress does not exist (yet).', $filtered_items[0]['message'] ); | |||
| $this->assertStringContainsString( 'Tested up to: 6.1', $filtered_items[1]['message'] ); | |||
There was a problem hiding this comment.
Not sure why this test was affected by the PR.
There was a problem hiding this comment.
Yeap. I think that is because of the array of elements.
There was a problem hiding this comment.
$filtered_items = array_values( wp_list_filter( $errors['readme.md'][0][0], array( 'code' => 'nonexistent_tested_upto_header' ) ) ); If we use array_values() here we could make test more robust and it will whatever position this exists in the $errors array.
|
@ernilambar I'm having this problem: How could avoid that? |
|
I've solved. I saw where to avoid that directive. |
Fixes #885