PHP 8.5 support #2950

bgrgicak · 2025-11-27T09:27:35Z

🚧 WIP

What is this PR doing?

Adds PHP 8.5 to Playground.

Additionally, it solves a bug where the php-chunk-alloc-zend-assert patch wasn't correctly applied to PHP versions before PHP 8.3.

Testing Instructions

Go to http://localhost:5400/website-server/ and switch the PHP version to 8.5.
Confirm that WordPress is functional and you can update the site in the site editor
Go to /phpinfo.php, confirm the php version it 8.5
Start Playground CLI nx dev playground-cli server --php=8.5
Confirm that WordPress is functional and you can update the site in the site editor
Go to PHP info, confirm the php version it 8.5

…P 8.3

…d part of PHP 8.5+

bgrgicak · 2025-11-27T13:48:19Z

I still need to recompile older PHP versions to fix Apply php-chunk-alloc-zend-assert.patch to PHP versions older than PHP 8.3 and resolve the failing tests.

bgrgicak · 2025-11-28T06:10:40Z

packages/php-wasm/compile/php/Dockerfile

+	if [[ "${PHP_VERSION:0:3}" < '8.3' ]]; then \
+		git apply --no-index /root/php-chunk-alloc-zend-assert.patch -v; \
+	elif [[ "${PHP_VERSION:0:3}" == '8.3' ]]; then \
+		git apply --no-index /root/php-chunk-alloc-zend-assert-8.3.patch -v; \
+	elif [[ "${PHP_VERSION:0:3}" == '8.4' ]]; then \
+		git apply --no-index /root/php-chunk-alloc-zend-assert-8.4.patch -v; \
+	elif [[ "${PHP_VERSION:0:3}" == '8.5' ]]; then \
+		git apply --no-index /root/php-chunk-alloc-zend-assert-8.5.patch -v; \
+	fi && \


While adding the PHP 8.5 patch, I noticed that patches for PHP versions before 8.3weren't applied.

bgrgicak · 2025-11-28T06:11:46Z

packages/php-wasm/compile/php/Dockerfile

+		# Add the dummy opcache_module.c to the list of files to build for PHP < 8.4.0.
+		# PHP 8.5 made OPcache a non-optional part of PHP https://wiki.php.net/rfc/make_opcache_required
+		if [[ "${PHP_VERSION:0:1}" -lt "8" || ("${PHP_VERSION:0:1}" -eq "8" && "${PHP_VERSION:2:1}" -lt "4") ]]; then \
+			/root/replace.sh 's/shared_alloc_mmap.c/shared_alloc_mmap.c opcache_module.c/g' /root/php-src/ext/opcache/config.m4; \
+		fi; \


PHP 8.5 made OPcache a non-optional part so we don't need to add the dummy opcache_module.c file to the list of files to build.

cc @zaerl – any thoughts?

cc @zaerl – any thoughts?

It is now a static lib. Having a -lt 5 check is ok. https://github.com/php/php-src/pull/18660/files#diff-fba8aed1e512099e6635bd4d9ffd939e0489105bc6b2c68d0bfe1abb0ee1007cL29

bgrgicak · 2025-11-28T12:34:08Z

I'm currently working on compiling XDebug for PHP 8.5.

adamziel · 2025-11-28T13:50:12Z

@bgrgicak feel free to poke @mho22 about XDebug

bgrgicak · 2025-11-28T18:04:12Z

Xdebug and Intl are now compiling. Next step I need to remove curl_close from tests as it's deprecated in PHP 8.5.

bgrgicak · 2025-11-28T18:49:05Z

packages/php-wasm/compile/shared/intl/Dockerfile

+	OPCACHE_FLAGS=""; \
+	if [[ "${PHP_VERSION:0:1}" -ge "8" && "${PHP_VERSION:2:1}" -ge "5" ]]; then \
+		OPCACHE_FLAGS="--enable-opcache --disable-opcache-jit --disable-huge-code-pages"; \
+	else \
+		OPCACHE_FLAGS="--disable-opcache"; \
+	fi; \


Because PHP 8.5 made Opcache required, we need to enable it during Intl compilation.

bgrgicak · 2025-11-28T18:49:26Z

packages/php-wasm/compile/xdebug/Dockerfile

+	OPCACHE_FLAGS=""; \
+	if [[ "${PHP_VERSION:0:1}" -ge "8" && "${PHP_VERSION:2:1}" -ge "5" ]]; then \
+		OPCACHE_FLAGS="--enable-opcache --disable-opcache-jit --disable-huge-code-pages"; \
+	else \
+		OPCACHE_FLAGS="--disable-opcache"; \
+	fi; \


Because PHP 8.5 made Opcache required, we need to enable it during Xdebug compilation.

bgrgicak · 2025-11-28T18:53:30Z

packages/php-wasm/compile/xdebug/Dockerfile

+	if [[ "${PHP_VERSION:0:1}" -ge "8" && "${PHP_VERSION:2:1}" -ge "5" ]]; then \
+		export XDEBUG_BRANCH="master"; \


TODO change this to. xdebug_3_5 once it's released.
For this PR we could use 3.5.0alpha3.

Suggested change

if [[ "${PHP_VERSION:0:1}" -ge "8" && "${PHP_VERSION:2:1}" -ge "5" ]]; then \

export XDEBUG_BRANCH="master"; \

if [[ "${PHP_VERSION:0:1}" -ge "8" && "${PHP_VERSION:2:1}" -ge "5" ]]; then \

export XDEBUG_BRANCH="xdebug_3_5"; \

@adamziel would you recommend we use the 3.5.0alpha3 version of Xdebug here, or wait with PHP 8.5 support until Xdebug releases 3.5?

I'm thinking of shipping it with 3.5.0alpha3 if everything works correctly and recompile only Xdebug once 3.5 is released.

bgrgicak · 2025-11-28T19:04:18Z

packages/playground/website/playwright/e2e/blueprints.spec.ts

 					curl_setopt($ch, CURLOPT_TCP_NODELAY, 0);
 					curl_setopt($ch, CURLOPT_RETURNTRANSFER, 1);
 					$result = curl_exec($ch);
-					curl_close($ch);


Since PHP 8.0 curl_close isn't required as the handle is released automatically when the CurlHandle object falls out of scope or is garbage-collected. (source)

I'm not sure if I should add curl_close for PHP 7 tests, or if it's ok to leave it as-is.

bgrgicak added 2 commits November 27, 2025 09:48

Add PHP 8.5 support

cfe647d

Apply php-chunk-alloc-zend-assert.patch to PHP versions older than PH…

9327646

…P 8.3

bgrgicak self-assigned this Nov 27, 2025

bgrgicak added [Type] Enhancement New feature or request [Feature] PHP.wasm [Package][@php-wasm] Web [Package][@php-wasm] Node [Package][@wp-playground] Blueprints labels Nov 27, 2025

bgrgicak added 2 commits November 27, 2025 11:00

Merge branch 'trunk' into add/php-8.5-support

65ad10b

Don't add dummy opcache module for PHP 8.5 since OPcache is a require…

6c7433f

…d part of PHP 8.5+

Recompile all PHP versions

311e190

bgrgicak commented Nov 28, 2025

View reviewed changes

bgrgicak added 2 commits November 28, 2025 07:17

Merge branch 'trunk' into add/php-8.5-support

83c4a2b

Recompile to resolve merge conflicts

91e1fb9

Fix XDebug support in PHP 8.5

9465a44

Fix Intl support in PHP 8.5

6c53605

bgrgicak added 2 commits November 28, 2025 19:38

Remove curl_close

6e7b684

Merge remote-tracking branch 'origin' into add/php-8.5-support

5f9010c

bgrgicak commented Nov 28, 2025

View reviewed changes

bgrgicak added 3 commits November 28, 2025 21:17

Recompile

997ab16

Use Xdebug 3.5.0alpha3 for PHP 8.5

4d64b75

Merge branch 'trunk' into add/php-8.5-support

b0491fe

		if [[ "${PHP_VERSION:0:1}" -ge "8" && "${PHP_VERSION:2:1}" -ge "5" ]]; then \
		export XDEBUG_BRANCH="master"; \

PHP 8.5 support #2950

Are you sure you want to change the base?

PHP 8.5 support #2950

Uh oh!

Conversation

bgrgicak commented Nov 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What is this PR doing?

Testing Instructions

Uh oh!

bgrgicak commented Nov 27, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bgrgicak commented Nov 28, 2025

Uh oh!

adamziel commented Nov 28, 2025

Uh oh!

bgrgicak commented Nov 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

bgrgicak commented Nov 27, 2025 •

edited

Loading

bgrgicak commented Nov 28, 2025 •

edited

Loading